Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notion of BlindedBlobsBundle #7674

Merged
merged 14 commits into from
Nov 8, 2023
Merged

Remove notion of BlindedBlobsBundle #7674

merged 14 commits into from
Nov 8, 2023

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Nov 7, 2023 •
edited
Loading

PR Description

  • Remove BlindedBlobsBundle from BuilderBid
  • Pass blobKzgCommitments to HeaderWithFallbackData
  • Create BlobKzgCommitmentsSchema to pass in the SchemaDefinitionsDeneb for blocks and builder bids and simplify creation from BlobsBundle
  • Rename randomSszKzgCommitmentsList to randomBlobKzgCommitments in DataStructureUtil
  • Removed BlindedBlobsBundle all around the project.
  • Set blobKzgCommitments from the BuilderBid instead of the BlindedBlobsBundle during block production
  • Changed tests accordingly

Fixed Issue(s)

helps with builder block production flow for #7654

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the builder_bid_deneb branch 2 times, most recently from 001a507 to 5e3507c Compare November 8, 2023 09:29
zilm13
zilm13 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But I see we have already several places where we receive but don't validate structures with kzgCommitments/blobs that they shouldn't exceed maxBlobsPerBlock. This should be addressed somewhere but it's ok if it's a separate PR

@StefanBratanov StefanBratanov changed the title Remove BlindedBlobsBundle from the BuilderBid Remove notion of BlindedBlobsBundle Nov 8, 2023
@StefanBratanov StefanBratanov enabled auto-merge (squash) November 8, 2023 15:03
@StefanBratanov StefanBratanov merged commit 5ce164c into Consensys:master Nov 8, 2023
3 checks passed
@StefanBratanov StefanBratanov deleted the builder_bid_deneb branch November 9, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @zilm13